BUG: resample with asfreq ignores origin if the dataframe has a fixed frequency #62725 #62763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floura-angel
changed the title
mroeschke
requested changes
Oct 20, 2025
Comment on lines
1004
to
1010
| exp_idx = pd.to_datetime( | ||
| [ | ||
| "2025-10-17 17:15:00", | ||
| "2025-10-17 17:16:00", | ||
| "2025-10-17 17:17:00", | ||
| ] | ||
| ).astype(result.index.dtype) # match time unit (s/us/ns) |
Member
There was a problem hiding this comment.
Can you construct a DatetimeIndex with freq= so we don't need to use check_freq=False?
natmokval
reviewed
Oct 20, 2025
mroeschke
reviewed
Oct 30, 2025
Comment on lines
1008
to
1010
| date_range("2025-10-17 17:15:00", periods=3, freq="min").astype( | ||
| result.index.dtype | ||
| ), |
Member
There was a problem hiding this comment.
Could you pass a list of Timestamps to the pd.DatetimeIndex constructor and pass the dtype as well? (For context, tests should minimize the use of extraneous APIs where possible.)
Contributor
Author
There was a problem hiding this comment.
Got it, updated. Thanks
mroeschke
approved these changes
Nov 4, 2025
Member
|
Thanks @floura-angel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resamplewithasfreqignoresoriginif the dataframe has a fixed frequency #62725doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.PR Summary
Bug in :meth:
DataFrame.resample.asfreqwhere fixed-frequency indexes withoriginignored alignmentand returned incorrect values. Now
originandoffsetare respected. (:issue:62725)